Skip to content

Add definition for the Olimex MOD-WIFI-ESP8266(-DEV) boards #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2015

Conversation

Imroy
Copy link
Contributor

@Imroy Imroy commented May 6, 2015

No description provided.

modwifi.build.f_cpu=80000000L
modwifi.build.board=MOD_WIFI_ESP8266
modwifi.build.core=esp8266
modwifi.build.variant=modwifi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pins_arduino.h for this variant is identical to generic. Do we really need a variant for this module? It doesn't have pin numbers redefined, as far as i can tell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose not. The role of each pin is printed in the silkscreen, so there's no reason to assign "D0", etc. Just use the GPIO numbers directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then we can change this to modwifi.build.variant=generic and delete hardware/esp8266com/esp8266/variants/modwifi

igrr added a commit that referenced this pull request May 7, 2015
Add definition for the Olimex MOD-WIFI-ESP8266(-DEV) boards
@igrr igrr merged commit 3bdabe9 into esp8266:esp8266 May 7, 2015
igrr added a commit that referenced this pull request Oct 29, 2015
Add definition for the Olimex MOD-WIFI-ESP8266(-DEV) boards
Normola pushed a commit to Normola/Arduino that referenced this pull request Feb 19, 2020
Fixed round buttons in style.css and data.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants